Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeBlock] Add new annotations feature #6564

Closed
elizabetdev opened this issue Jan 31, 2023 · 0 comments · Fixed by #6580
Closed

[EuiCodeBlock] Add new annotations feature #6564

elizabetdev opened this issue Jan 31, 2023 · 0 comments · Fixed by #6580
Assignees

Comments

@elizabetdev
Copy link
Contributor

elizabetdev commented Jan 31, 2023

The idea for this new feature is to highlight specific lines in EuiCodeBlock and provide additional information in a EuiPopover.

Visually it should look like the following:

beacon-annotation@2x

Feature spec

The feature spec can be found here.

Notes

For the initial version, I think we should restrict the icon usage. The purpose of a EuiAnnotation is to highlight specific lines in an editor and provide additional information. So the icon should be indicative of this.

@elizabetdev elizabetdev self-assigned this Jan 31, 2023
@elizabetdev elizabetdev changed the title [EuiAnnotation] Add new component [EuiCodeBlock] Add new annotations feature Jan 31, 2023
@cee-chen cee-chen self-assigned this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants