Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSelectable] Non-searchable listboxes' focus rings #6633

Closed
cee-chen opened this issue Mar 6, 2023 · 0 comments · Fixed by #6637
Closed

[EuiSelectable] Non-searchable listboxes' focus rings #6633

cee-chen opened this issue Mar 6, 2023 · 0 comments · Fixed by #6637
Assignees
@cee-chen
Labels
accessibility - keyboard bug good first issue

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Mar 6, 2023 •
edited
Loading

Originally posted in #6631 (comment)

https://elastic.github.io/eui/#/forms/selectable

Non-searchable EuiSelectables have this slightly-but-not-really visible focus ring around the listbox. This should focus ring should be visually removed for mouse users, and likely made clearer for keyboard users (via :focus-visible).

FF:

Chrome:
@cee-chen cee-chen mentioned this issue Mar 6, 2023
Merged
8 tasks
@cee-chen cee-chen changed the title [Attaching to a random line for threading] [EuiSelectable] Non-searchable listboxes' focus rings Mar 6, 2023
@cee-chen cee-chen self-assigned this Mar 7, 2023
@cee-chen cee-chen mentioned this issue Mar 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cee-chen cee-chen

Labels
accessibility - keyboard bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiSelectable] Fix focus ring on non-searchable listboxes cee-chen/eui
1 participant
@cee-chen