Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAccordion][AXE-CORE]: Interactive content in trigger must not have aria-expanded attribute #6689

Closed
1Copenut opened this issue Apr 5, 2023 · 0 comments · Fixed by #6694

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Apr 5, 2023

Description

@darnautov brought this issue to our attention with Kibana PR 154237.

The EuiAccordion allows users to add interactive content next to the expand/collapse button as a way to surface multiple controls. When we do this, axe-core is throwing an error because we have an aria-expanded="true | false" attribute on a non-button element.

I'd recommend we check the buttonElement prop against the accepted values and conditionally render the aria-expanded attribute on accordion.tsx#L377 only if the ButtonElement === 'button'.

WCAG guidance


Screen Shot 2023-04-05 at 10 51 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant