Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Redesign grid header #7137

Closed
4 tasks done
Tracked by #168084 ...
kertal opened this issue Aug 29, 2023 · 5 comments · Fixed by #7371
Closed
4 tasks done
Tracked by #168084 ...

[EuiDataGrid] Redesign grid header #7137

kertal opened this issue Aug 29, 2023 · 5 comments · Fixed by #7371
Assignees
Labels
feature request task A task associated with a larger Meta issue

Comments

@kertal
Copy link
Member

kertal commented Aug 29, 2023

Is your feature request related to a problem? Please describe.
We are giving Discover a visual refresh, this issue aims to summarize the changes in the grid header section.

Describe the solution you'd like
For our upcoming Discover redesign there are 4 changes requested (Figma)

  • Change the icon for additional actions to boxesVertical
  • Show the additional actions on hover or focus of the heading cell
  • Allow columns to be right - aligned for e.g. numeric values
  • Show the sorting arrow on the right side of the columns name
Bildschirmfoto 2023-08-29 um 10 04 01

Describe alternatives you've considered

  • A local CSS based change, but for these changes it doesn't seem to be possible
  • Make this part configureable so we could apply these change locally
@kertal
Copy link
Member Author

kertal commented Sep 11, 2023

@cee-chen do you thing this could/should also be a render props powered changes? FYI @jughosta

@cee-chen
Copy link
Contributor

cee-chen commented Sep 11, 2023

Hmmmmmm. This one feels a bit trickier because I could see all these changes simply being default changes to the baseline datagrid instead of configurable changes. They feel generic enough that it makes sense and changing it just once would make datagrid more consistent across all of Kibana/Elastic.

@andreadelrio what do you think? Are these Discover-only changes or data-grid-wide changes?

@kertal
Copy link
Member Author

kertal commented Sep 11, 2023

Hmmmmmm. This one feels a bit trickier because I could see all these changes simply being default changes to the baseline datagrid instead of configurable changes. They feel generic enough that it makes sense and changing it just once would make datagrid more consistent across all of Kibana/Elastic.

for me this makes sense 👍

@JasonStoltz JasonStoltz added the task A task associated with a larger Meta issue label Sep 11, 2023
@andreadelrio
Copy link
Contributor

Hmmmmmm. This one feels a bit trickier because I could see all these changes simply being default changes to the baseline datagrid instead of configurable changes. They feel generic enough that it makes sense and changing it just once would make datagrid more consistent across all of Kibana/Elastic.

@andreadelrio what do you think? Are these Discover-only changes or data-grid-wide changes?

I think this should be data-grid-wide changes and the new default.

@cee-chen
Copy link
Contributor

Closed by #7371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request task A task associated with a larger Meta issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants