Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New docs] Create StoryEmbed component #7393

Closed
Tracked by #7401
tkajtoch opened this issue Dec 4, 2023 · 2 comments
Closed
Tracked by #7401

[New docs] Create StoryEmbed component #7393

tkajtoch opened this issue Dec 4, 2023 · 2 comments
Assignees
Labels
New EUI site task A task associated with a larger Meta issue

Comments

@tkajtoch
Copy link
Member

tkajtoch commented Dec 4, 2023

Summary

StoryEmbed component is a helper component that renders <iframe>d Storybook stories and docs views based on a given id or path.

Acceptance Criteria

  • StoryEmbed should render an <iframe> element with auto-generated src
    • The src value should be generated using the STORYBOOK_ROOT_URL environment variable, the type prop, and the id or path props
  • it should allow width and height customization and default to width="100%" when no value is provided
@JasonStoltz
Copy link
Member

@tkajtoch What is the status of this?

@JasonStoltz JasonStoltz added the task A task associated with a larger Meta issue label Mar 25, 2024
@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen reopened this Oct 14, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
@tkajtoch
Copy link
Member Author

We decided to not embed stories as interactive examples and instead implemented an interactive example component based on react-live.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New EUI site task A task associated with a larger Meta issue
Projects
None yet
Development

No branches or pull requests

3 participants