Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align EUI services import and code examples #976

Closed
markov00 opened this issue Jul 9, 2018 · 1 comment
Closed

Align EUI services import and code examples #976

markov00 opened this issue Jul 9, 2018 · 1 comment

Comments

@markov00
Copy link
Member

markov00 commented Jul 9, 2018

So I've seen a difference between the EUI consuming docs and the code examples rendered in the EUI style guide.

The consuming reports that you can import services (and in the near feature experimental components like XYChart #975) using the following

import { keyCodes } from '@elastic/eui/lib/services';

but on the style guide code we are rendering imports as the following

import { keyCodes } from '@elastic/eui/services';

The regex also doesn't check for subfolders of services like the one used for tables rendering code in the style guide like

import { formatDate } from '../../../../../src/services/format';
@markov00
Copy link
Member Author

Ok aligned as @elastic/eui/lib/ after 7d31e89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant