Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for new Add Data tutorials #1033

Closed
alexfrancoeur opened this issue Jul 19, 2018 · 9 comments
Closed

Add icons for new Add Data tutorials #1033

alexfrancoeur opened this issue Jul 19, 2018 · 9 comments
Labels

Comments

@alexfrancoeur
Copy link

We have a ton of Beats beta modules we'd like to add to the Add Data UI. I went through and found these icons and resized appropriately. The only one I wasn't able to resize was the postgressql icon, the border doesn't seem to want to shrink.

icons.zip

If we can get these into EUI ASAP, we should be able to get the icons in for 6.4

cc: @cchaos @snide

@tsg
Copy link

tsg commented Jul 19, 2018

Thank you for collecting the icons, they look good to me.

@snide
Copy link
Contributor

snide commented Jul 19, 2018

I'll take care of these.

@alexfrancoeur
Copy link
Author

more_icons.zip

@snide a few more we need to add.

@ruflin @tsg I added two Golang icons. One is the gopher and the other is their newly updated logo from April that may not be as recognizable. Wondering what your thought are here. Which should we use?

Also, it looks like Zookeeper is an Apache product. Can we use the Apache feather logo here?

@ruflin
Copy link
Member

ruflin commented Jul 23, 2018

For Golang I would stick to the gopher. I didn't even know there is new logo :-)
For zookeeper if I think apache the webserver is the only apache project I would use the feature. What about the one below?
zookeeper_small

I assume for us using these icons a new release of EUI must be shipped and afterwards we open a PR with it the usage of the icons against Kibana?

@alexfrancoeur
Copy link
Author

For Golang I would stick to the gopher. I didn't even know there is new logo :-)

Noted.

For zookeeper if I think apache the webserver is the only apache project I would use the feature.

I did see that icon as well. I'm less familiar with the technology, so I'm not sure what's normally used to identify it. If you think this is better than using a generic zookeeper icon, that works for me. I can make this 30px. What do you think @tsg?

I assume for us using these icons a new release of EUI must be shipped and afterwards we open a PR with it the usage of the icons against Kibana?

I'd assume so but will defer to @snide on this one.

@tsg
Copy link

tsg commented Jul 23, 2018

For zookeeper, the icon from @ruflin's is the best one, from what I know.

@alexfrancoeur
Copy link
Author

@snide updated to a single zip file with the new zookeeper logo and only the old gopher logo for Golang. all_icons.zip

@snide
Copy link
Contributor

snide commented Jul 24, 2018

Just FYI. We won't be adding icons for anything that isn't provided in a vector format. I'll update my PR with the latest of what's available.

@alexfrancoeur
Copy link
Author

Thanks @snide, I'll try and do more digging for logos that I couldn't find vectors for 🤕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants