Update global date picker #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snide Ready for a look through. I've incorporated the extra stuff. |
|
I'll scan this tonight. Thanks! |
|
Hmm. Either my local got messed or I think you forgot to commit. 😈 |
|
Yeah... I forgot to push.... |
snide
approved these changes
Nov 6, 2018
cchaos
commented
Nov 8, 2018
added 5 commits
November 16, 2018 13:54
- overflow scrolling per section - time range arrows - timer options
cchaos
force-pushed
the
update-global-date-picker
branch
from
3e949bd to
9e44a7e
Compare
|
Ok, this is now done. @chandlerprall can you do a real quick pass at the code (esp the TS defs?) |
chandlerprall
suggested changes
Nov 20, 2018
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
|
@chandlerprall , I've committed your TS def fixes |
chandlerprall
suggested changes
Nov 20, 2018
|
Ahh youp, thx. Updated |
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Altered global date/time picker to use buttons instead of date inputs and adds the update button. The component just needed a few adjustments, mostly on the pattern side.
Still needs:
---Includes a fix for #1207 (don’t shrink date picker icon)
Checklist
[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios(different PR for that)