Adds possibility to disable checkboxes individually in an EuiCheckboxGroup component #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at is passed to the EuiCheckboxGroup so that checkboxes in a group can be individually disabled
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
This was referenced Nov 19, 2019
ffknob
changed the title
chandlerprall
suggested changes
Nov 20, 2019
| @@ -21,7 +21,7 @@ export const EuiCheckboxGroup = ({ | |||
| id={option.id} | |||
| checked={idToSelectedMap[option.id]} | |||
| label={option.label} | |||
| disabled={disabled} | |||
| disabled={disabled || option.disabled} | |||
There was a problem hiding this comment.
disabled needs to be added to this component's propTypes.options shape definition (lines 34-39). Similarly, the typescript definition needs to be updated -
| @@ -56,4 +56,22 @@ describe('EuiCheckboxGroup (mocked checkbox)', () => { | |||
|
|
|||
| expect(component).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Thanks for the test!
chandlerprall
approved these changes
Nov 20, 2019
|
jenkins test this |
|
Thanks again @ffknob ! |
Glad to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2539
Added
disabledoption to theoptionattribute of theoptionsobject that is passed to theEuiCheckboxGroupso that checkboxes in a group can be individually disabledChecklist