Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing API for checkbox without a label #541

Closed
arkwright opened this issue Mar 19, 2018 · 1 comment
Closed

Confusing API for checkbox without a label #541

arkwright opened this issue Mar 19, 2018 · 1 comment
Assignees

Comments

@arkwright
Copy link
Contributor

arkwright commented Mar 19, 2018

As per #540, an EuiCheckbox without a label prop must also receive type="inList", otherwise as of 0.0.22 it will be unclickable with a mouse. I was using a checkbox, read through the source code, was totally aware of type="inList", but didn't think to use it due to the seeming non sequitur of lists and lack-of-checkboxes.

@arkwright
Copy link
Contributor Author

@cchaos said:

Perhaps we just need to change that prop name, or add an alias to the prop name, that says noLabel and appends that class. And we should probably add the same ability to the radio buttons as well.

I like where you're going with noLabel. Semantically and intuitively, I would ideally like to see a checkbox without a label prop simply render correctly, as I tried to do in #540. Even if it's renamed to noLabel, API consumers twice need to specify that a label is not being used: by omitting the label, and then also by adding, "no, really, this definitely does not have a label."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants