Rename directories to not contain - in packages

[ruflin]

To unify the naming of all directories and configs, only _ are used moving forward. This means the ingest-pipeline directories must be renamed to ingest_pipeline. In the package storage this was already done by duplicating the directories: elastic/package-storage#108 Adjustments to Kibana are here: elastic/kibana#70320

I wanted now to adjust it in integrations repository. Copying the directories / renaming is easy, here is a leftover script: https://github.com/elastic/package-storage/blob/master/packages/main.go But it was unclear to me where it happens in the generation code. It seems it already takes the name from the Beat as I couldn't find ingest-pipeline directory creation in the code.

[mtojek]

But it was unclear to me where it happens in the generation code. It seems it already takes the name from the Beat as I couldn't find ingest-pipeline directory creation in the code.

https://github.com/elastic/integrations/blob/master/dev/import-beats/packages.go#L328

[ruflin]

@mtojek Glad you pointed me to this. Seems like this one went missing during the renaming. Lets get in elastic/package-registry#581 first then.

[ruflin]

I filed #153 as draft so we can continue the work as soon as the registry is changed.

[mtojek]

@ruflin can we close this issue?

[ruflin]

@mtojek Yes.

@ycombinator Could we make sure this is "enforced" also in the package spec somehow for all directories?

[ycombinator]

I just checked the 1.0 spec and this is already enforced.

$ git grep -A1 "type: folder"
dataset/_dev/spec.yml:      type: folder
dataset/_dev/spec.yml-      name: test
--
dataset/_dev/test/spec.yml:      type: folder
dataset/_dev/test/spec.yml-      name: pipeline
--
dataset/spec.yml:    type: folder
dataset/spec.yml-    pattern: '[a-z0-9][a-z0-9_]+[a-z0-9]'
--
dataset/spec.yml:      type: folder
dataset/spec.yml-      name: fields
--
dataset/spec.yml:      type: folder
dataset/spec.yml-      name: agent
--
dataset/spec.yml:        type: folder
dataset/spec.yml-        name: stream
--
dataset/spec.yml:      type: folder
dataset/spec.yml-      name: elasticsearch
--
dataset/spec.yml:        type: folder
dataset/spec.yml-        name: ingest_pipeline
--
dataset/spec.yml:      type: folder
dataset/spec.yml-      name: "test"
--
dataset/spec.yml:      type: folder
dataset/spec.yml-      name: _dev
--
kibana/spec.yml:      type: folder
kibana/spec.yml-      name: dashboard
--
kibana/spec.yml:      type: folder
kibana/spec.yml-      name: visualization
--
kibana/spec.yml:      type: folder
kibana/spec.yml-      name: search
--
kibana/spec.yml:      type: folder
kibana/spec.yml-      name: map
--
kibana/spec.yml:      type: folder
kibana/spec.yml-      name: "index_pattern"
--
spec.yml:    type: folder
spec.yml-    name: dataset
--
spec.yml:    type: folder
spec.yml-    name: docs
--
spec.yml:    type: folder
spec.yml-    name: kibana

Or if you prefer GitHub references:

• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/spec.yml#L23-L24
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/spec.yml#L28-L29
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/spec.yml#L32-L33
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L5-L6
• https://github.com/elastic/package-spec/blob/master/versions/1/dataset/spec.yml#L17-L18
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L22-L23
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L28-L29
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L33-L34
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L38-L39
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L62-L63
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/spec.yml#L66-L67
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/kibana/spec.yml#L5-L6
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/kibana/spec.yml#L14-L15
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/kibana/spec.yml#L23-L24
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/kibana/spec.yml#L32-L33
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/kibana/spec.yml#L41-L42
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/_dev/spec.yml#L5-L6
• https://github.com/elastic/package-spec/blob/f45b05c887b5d62dea8f5c21577520a0e113716c/versions/1/dataset/_dev/test/spec.yml#L5-L6

[ruflin]

@ycombinator As usual, you are a step ahead 🎉