Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TI_CIF3] Add support for IOC expiration #7358

Closed
kcreddy opened this issue Aug 11, 2023 · 5 comments · Fixed by #9550
Closed

[TI_CIF3] Add support for IOC expiration #7358

kcreddy opened this issue Aug 11, 2023 · 5 comments · Fixed by #9550
Assignees
Labels
enhancement New feature or request Integration:ti_cif3 Collective Intelligence Framework v3 Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]

Comments

@kcreddy
Copy link
Contributor

kcreddy commented Aug 11, 2023

Individual tracking issue for ti_cif3 package for adding IOC expiration support.
Meta Issue - #5369

@kcreddy kcreddy added enhancement New feature or request Integration:ti_cif3 Collective Intelligence Framework v3 Team:Security-External Integrations labels Aug 11, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy self-assigned this Aug 11, 2023
@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 11, 2023

We currently have 1 datastream feed which use the CIFv3 API /feed documented here with parameters such as itype, confidence, tags, hours, reporttime to fetch only relevant filtered indicators since last reported time.

The repository which supports the v3 API is now archived. There is also a CIFv5 that is available at https://github.com/csirtgadgets/cif-v5
None of the v3 API or v5 API have documentation which provides information on indicator expiration. I created an issue on their repository to confirm it.

Issue - csirtgadgets/cif-v5#43

@jamiehynds
Copy link

@mdavis332 I know it's been awhile since you built the integration, but do you have any familiarity with the CIFv5 API and how it handles IoC expiration?

@mdavis332
Copy link
Contributor

@mdavis332 I know it's been awhile since you built the integration, but do you have any familiarity with the CIFv5 API and how it handles IoC expiration?

Hi @jamiehynds, I see that Wes already replied to @kcreddy's issue at csirtgadgets/cif-v5#43. Although his answer his for CIFv5, it's mostly the same for CIFv3. The /feed endpoint handles looking back a certain number of days automatically based on itype if a reporttime field isn't specified during the indicator feed pull. Therefore, each pull will only ever yield indicators from that reporttime or forward and there's no explicit expiry field in the schema (the clients get to handle how far back they want to pull indicators for).

Hope that helps!

@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 12, 2023

Thanks @mdavis332 for the info.
Yes we are using reporttime in the url parameter and fetching the latest indicators since previous reporttime.
Since there is no explicit expiry field here, we will go with Wes suggestion on the defaults provided: csirtgadgets/cif-v5#43 (comment)

@narph narph added Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] and removed Team:Security-External Integrations labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:ti_cif3 Collective Intelligence Framework v3 Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants