Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension field issue in Metrics Datastream when ecs mappings template from ES is adopted #8623

Open
ishleenk17 opened this issue Dec 1, 2023 · 1 comment

Comments

@ishleenk17
Copy link
Contributor

There is a plan to migrate the ecs mappings template provided by ElasticSearch. As one of the tasks once the templates are added the ecs.yml would be removed as mentioned in Step 4.

When the ecs.yml is removed in metrics datastream, it can be an issue since there are many fields in ecs which are dimensions field.
We need a plan on how to handle these dimensions field.

@felixbarny
Copy link
Member

As one of the tasks once the templates are added the ecs.yml would be removed as mentioned in #8542.

I think we shouldn't do that step for metric integrations. At least, we shouldn't remove fields that are marked as dimensions from the ecs/field yml files for metric integrations.

For OTel-based integrations, we can just rely on the default mappings and mark all fields in *attributes.* as a dimension.

Therefore, I don't feel like there's any urgency to come up with a solution to completely remove all field definitions for our existing metric integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants