Merge branch 'master' into 46445-add-ml-links

Author: weltenwort

.eslintignore

@@ -33,6 +33,7 @@ bower_components
 /x-pack/legacy/plugins/**/__tests__/fixtures/**
 /packages/kbn-interpreter/src/common/lib/grammar.js
 /x-pack/legacy/plugins/canvas/canvas_plugin
+/x-pack/legacy/plugins/canvas/shareable_runtime/build
 /x-pack/legacy/plugins/canvas/storybook
 /x-pack/legacy/plugins/canvas/canvas_plugin_src/lib/flot-charts
 /x-pack/legacy/plugins/infra/common/graphql/types.ts

docs/developer/core/development-elasticsearch.asciidoc

@@ -3,7 +3,7 @@
 
 Kibana exposes two clients on the server and browser for communicating with elasticsearch.
 There is an 'admin' client which is used for managing Kibana's state, and a 'data' client for all
-other requests.  The clients use the {client-ref}/javascript-api/current/index.html[elasticsearch.js library].
+other requests.  The clients use the {jsclient}/javascript-api/current/index.html[elasticsearch.js library].
 
 [float]
 [[client-server]]

docs/development/core/public/kibana-plugin-public.chromebreadcrumb._data-test-subj_.md

@@ -2,21 +2,11 @@
 
 [Home](./index.md) > [kibana-plugin-public](./kibana-plugin-public.md) > [ChromeBreadcrumb](./kibana-plugin-public.chromebreadcrumb.md)
 
-## ChromeBreadcrumb interface
+## ChromeBreadcrumb type
 
 
 <b>Signature:</b>
 
 ```typescript
-export interface ChromeBreadcrumb 
+export declare type ChromeBreadcrumb = EuiBreadcrumb;
 ```
-
-## Properties
-
-|  Property | Type | Description |
-|  --- | --- | --- |
-|  ["data-test-subj"](./kibana-plugin-public.chromebreadcrumb._data-test-subj_.md) | <code>string</code> |  |
-|  [href](./kibana-plugin-public.chromebreadcrumb.href.md) | <code>string</code> |  |
-|  [onClick](./kibana-plugin-public.chromebreadcrumb.onclick.md) | <code>MouseEventHandler&lt;HTMLButtonElement&gt;</code> |  |
-|  [text](./kibana-plugin-public.chromebreadcrumb.text.md) | <code>string</code> |  |
-

docs/development/core/public/kibana-plugin-public.chromebreadcrumb.href.md

@@ -91,18 +91,17 @@ export interface VizRenderContext {
 }
 
 export type VizRenderer = (context: VizRenderContext, domElement: HTMLElement) => () => void;
+// When a renderer is bound via `contextContainer.createHandler` this is the type that will be returned.
+type BoundVizRenderer = (domElement: HTMLElement) => () => void;
 
 class VizRenderingPlugin {
-  private readonly vizRenderers = new Map<string, ((domElement: HTMLElement) => () => void)>();
+  private readonly contextContainer?: IContextContainer<VizRenderer>;
+  private readonly vizRenderers = new Map<string, BoundVizRenderer>();
 
   constructor(private readonly initContext: PluginInitializerContext) {}
 
   setup(core) {
-    this.contextContainer = core.context.createContextContainer<
-      VizRenderContext,
-      ReturnType<VizRenderer>,
-      [HTMLElement]
-    >();
+    this.contextContainer = core.context.createContextContainer();
 
     return {
       registerContext: this.contextContainer.registerContext,

docs/development/core/public/kibana-plugin-public.chromebreadcrumb.md

@@ -4,6 +4,8 @@
 
 ## ErrorToastOptions interface
 
+Options available for [IToasts](./kibana-plugin-public.itoasts.md) APIs.
+
 <b>Signature:</b>
 
 ```typescript

docs/development/core/public/kibana-plugin-public.chromebreadcrumb.onclick.md

@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-error: Error | HttpFetchError;
+error: Error | IHttpFetchError;
 ```