Merge branch 'master' of https://github.com/elastic/kibana into dynamic-style-time

Author: nickpeihl

CONTRIBUTING.md

@@ -309,12 +309,12 @@ Another tool we use for enforcing consistent coding style is EditorConfig, which
 Note that for VSCode, to enable "live" linting of TypeScript (and other) file types, you will need to modify your local settings, as shown below.  The default for the ESLint extension is to only lint JavaScript file types.
 
 ```json
-   "eslint.validate": [
-        "javascript",
-        "javascriptreact",
-        "typescript",
-        "typescriptreact",
-    ]
+"eslint.validate": [
+  "javascript",
+  "javascriptreact",
+  { "language": "typescript", "autoFix": true },
+  { "language": "typescriptreact", "autoFix": true }
+]
 ```
 
 ### Internationalization

docs/api/spaces-management.asciidoc

@@ -10,7 +10,7 @@ Manage your {kib} spaces.
 * <<spaces-api-get-all, Get all {kib} spaces API>>
 * <<spaces-api-delete, Delete space API>>
 * <<spaces-api-copy-saved-objects, Copy saved objects to space API>>
-*<<spaces-api-resolve-copy-saved-objects-conflicts , Resolve copy saved objects to space conflicts API>>
+* <<spaces-api-resolve-copy-saved-objects-conflicts, Resolve copy saved objects to space conflicts API>>
 
 include::spaces-management/post.asciidoc[]
 include::spaces-management/put.asciidoc[]

docs/code/code-install-lang-server.asciidoc

@@ -1,14 +1,15 @@
 [[code-install-lang-server]]
 == Install language server
 
-*Code* comes with built-in language support for TypeScript. You can install additional languages as a {kib} plugin.
+*Code* comes with built-in language support for TypeScript. You can install additional languages as a {kib} plugin. Plugin's reduce the distribution size to run Code inside {kib}. Install only the languages needed for your indexed repositories. 
 
 [role="screenshot"]
 image::images/code-lang-server-tab.png[]
 
 For the current version, *Code* supports the following languages in addition to TypeScript:
 
 * `Java`
+* `GO`
 
 You can check the status of the language servers and get installation instructions on the *Language Servers* tab.  Make sure the status of the language server is `INSTALLED` or `RUNNING` after you restart the {kib} instance.
 [role="screenshot"]

docs/developer/plugin/development-plugin-resources.asciidoc

@@ -28,13 +28,13 @@ node scripts/generate_plugin my_plugin_name # replace "my_plugin_name" with your
 The Kibana directory must be named `kibana`, and your plugin directory should be located in the root of `kibana` in a `plugins` directory, for example:
 
 ["source","shell"]
------------
+----
 .
 └── kibana
     └── plugins
         ├── foo-plugin
         └── bar-plugin
---------
+----
 
 [float]
 ==== References in the code

docs/images/code-lang-server-status.png

@@ -10,6 +10,6 @@
 
 --
 
-include::graph/index.asciidoc[leveloffset=+1]
+include::graph/index.asciidoc[]
 
 include::ml/index.asciidoc[]

docs/images/code-lang-server-tab.png

@@ -81,25 +81,29 @@ describe(`running the plugin-generator via 'node scripts/generate_plugin.js plug
       await execa('yarn', ['build'], { cwd: generatedPath });
     });
 
-    it(`'yarn start' should result in the spec plugin being initialized on kibana's stdout`, async () => {
+    describe('with es instance', () => {
       const log = new ToolingLog();
+
       const es = createLegacyEsTestCluster({ license: 'basic', log });
-      await es.start();
-      await withProcRunner(log, async proc => {
-        await proc.run('kibana', {
-          cmd: 'yarn',
-          args: [
-            'start',
-            '--optimize.enabled=false',
-            '--logging.json=false',
-            '--migrations.skip=true',
-          ],
-          cwd: generatedPath,
-          wait: /ispec_plugin.+Status changed from uninitialized to green - Ready/,
+      beforeAll(es.start);
+      afterAll(es.stop);
+
+      it(`'yarn start' should result in the spec plugin being initialized on kibana's stdout`, async () => {
+        await withProcRunner(log, async proc => {
+          await proc.run('kibana', {
+            cmd: 'yarn',
+            args: [
+              'start',
+              '--optimize.enabled=false',
+              '--logging.json=false',
+              '--migrations.skip=true',
+            ],
+            cwd: generatedPath,
+            wait: /ispec_plugin.+Status changed from uninitialized to green - Ready/,
+          });
+          await proc.stop('kibana');
         });
-        await proc.stop('kibana');
       });
-      await es.stop();
     });
 
     it(`'yarn preinstall' should exit 0`, async () => {

docs/user/extend.asciidoc

@@ -21,7 +21,7 @@ import Url from 'url';
 
 import Axios, { AxiosRequestConfig } from 'axios';
 import parseLinkHeader from 'parse-link-header';
-import { ToolingLog, isAxiosResponseError } from '@kbn/dev-utils';
+import { ToolingLog, isAxiosResponseError, isAxiosRequestError } from '@kbn/dev-utils';
 
 const BASE_URL = 'https://api.github.com/repos/elastic/kibana/';
 
@@ -33,7 +33,11 @@ export interface GithubIssue {
   body: string;
 }
 
-type RequestOptions = AxiosRequestConfig & { safeForDryRun?: boolean };
+type RequestOptions = AxiosRequestConfig & {
+  safeForDryRun?: boolean;
+  maxAttempts?: number;
+  attempt?: number;
+};
 
 export class GithubApi {
   private readonly x = Axios.create({
@@ -78,7 +82,8 @@ export class GithubApi {
         issues.push(issue);
       }
 
-      const parsed = parseLinkHeader(resp.headers.link);
+      const parsed =
+        typeof resp.headers.link === 'string' ? parseLinkHeader(resp.headers.link) : undefined;
       if (parsed && parsed.next && parsed.next.url) {
         nextRequest = {
           safeForDryRun: true,
@@ -139,31 +144,64 @@ export class GithubApi {
     return resp.data.html_url;
   }
 
-  private async request<T>(options: RequestOptions, dryRunResponse: T) {
+  private async request<T>(
+    options: RequestOptions,
+    dryRunResponse: T
+  ): Promise<{
+    status: number;
+    statusText: string;
+    headers: Record<string, string | string[] | undefined>;
+    data: T;
+  }> {
     const executeRequest = !this.dryRun || options.safeForDryRun;
+    const maxAttempts = options.maxAttempts || 5;
+    const attempt = options.attempt || 1;
+
     this.log.verbose('Github API', executeRequest ? 'Request' : 'Dry Run', options);
 
-    if (executeRequest) {
-      try {
-        return await this.x.request<T>(options);
-      } catch (error) {
-        if (isAxiosResponseError(error)) {
-          throw new Error(
-            `[${error.config.method} ${error.config.url}] ${error.response.status} ${
-              error.response.statusText
-            } Error: ${JSON.stringify(error.response.data)}`
-          );
+    if (!executeRequest) {
+      return {
+        status: 200,
+        statusText: 'OK',
+        headers: {},
+        data: dryRunResponse,
+      };
+    }
+
+    try {
+      return await this.x.request<T>(options);
+    } catch (error) {
+      const unableToReachGithub = isAxiosRequestError(error);
+      const githubApiFailed = isAxiosResponseError(error) && error.response.status >= 500;
+      const errorResponseLog =
+        isAxiosResponseError(error) &&
+        `[${error.config.method} ${error.config.url}] ${error.response.status} ${error.response.statusText} Error`;
+
+      if ((unableToReachGithub || githubApiFailed) && attempt < maxAttempts) {
+        const waitMs = 1000 * attempt;
+
+        if (errorResponseLog) {
+          this.log.error(`${errorResponseLog}: waiting ${waitMs}ms to retry`);
+        } else {
+          this.log.error(`Unable to reach github, waiting ${waitMs}ms to retry`);
         }
 
-        throw error;
+        await new Promise(resolve => setTimeout(resolve, waitMs));
+        return await this.request<T>(
+          {
+            ...options,
+            maxAttempts,
+            attempt: attempt + 1,
+          },
+          dryRunResponse
+        );
       }
-    }
 
-    return {
-      status: 200,
-      statusText: 'OK',
-      headers: {},
-      data: dryRunResponse,
-    };
+      if (errorResponseLog) {
+        throw new Error(`${errorResponseLog}: ${JSON.stringify(error.response.data)}`);
+      }
+
+      throw error;
+    }
   }
 }

packages/kbn-plugin-generator/integration_tests/generate_plugin.test.js

@@ -51,9 +51,11 @@ describe('createFailureIssue()', () => {
           Array [
             "Failing test: some.classname - test name",
             "A test failed on a tracked branch
+
       \`\`\`
       this is the failure text
       \`\`\`
+
       First failure: [Jenkins Build](https://build-url)
 
       <!-- kibanaCiData = {\\"failed-test\\":{\\"test.class\\":\\"some.classname\\",\\"test.name\\":\\"test name\\",\\"test.failCount\\":1}} -->",