Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index patterns] type cleanup - disambigutate IFieldSubType #100186

Closed
mattkime opened this issue May 15, 2021 · 1 comment · Fixed by #112499
Closed

[index patterns] type cleanup - disambigutate IFieldSubType #100186

mattkime opened this issue May 15, 2021 · 1 comment · Fixed by #112499
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@mattkime
Copy link
Contributor 

export interface IFieldSubType {
  multi?: { parent: string };
  nested?: { path: string };
}

A field can't be both a multi field and a nested field yet the type allows both. We should disambiguate this type so this isn't possible.
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServices labels May 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime mentioned this issue May 15, 2021
Closed
63 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@mattkime mattkime changed the title [index patterns] type cleanup - disambiutate IFieldSubType [index patterns] type cleanup - disambigutate IFieldSubType Jul 5, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 6, 2021
@mattkime mattkime mentioned this issue Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data views] clarify field subtype typescript types mattkime/kibana
2 participants
@mattkime @elasticmachine