Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task manager] saved object mappings include "text" fields that are probably not needed to be full text searchable #101748

Closed
pmuellr opened this issue Jun 9, 2021 · 3 comments
Labels
estimate:small Small Estimated Level of Effort Feature:Task Manager Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. resilience Issues related to Platform resilience in terms of scale, performance & backwards compatibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Jun 9, 2021

The following fields are typed text, but can probably be made keyword. I'm actually even wondering if we need to enable searching over them at all. I would be surprised if we ever searched over these in the runtime code, and it's not clear to me if it would be helpful to have them searchable for diagnostic reasons.

"traceparent": {
"type": "text"
},
"params": {
"type": "text"
},
"state": {
"type": "text"
},

@pmuellr pmuellr added Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member Author

pmuellr commented Jun 9, 2021

Note that if we do change this to keyword, I also noticed these mappings do NOT have ignore_above set for the keyword types, which we absolutely must have, otherwise fields that exceed that length will cause create/update to error.

We should fix those in any case, unless for some reason they are no longer needed. Based on issue #100607, I think they are likely needed.

@gmmorris gmmorris added the Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. label Jun 30, 2021
@gmmorris gmmorris added loe:medium Medium Level of Effort resilience Issues related to Platform resilience in terms of scale, performance & backwards compatibility labels Jul 14, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@pmuellr
Copy link
Member Author

pmuellr commented Jul 10, 2024

During the great "stop indexing every field in your SOs!" effort, we stopped indexing these fields altogether, and they are left in the mappings document as comments (as we do elsewhere).

@pmuellr pmuellr closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:small Small Estimated Level of Effort Feature:Task Manager Project:AlertingPerformance Alerting team project for setting up tooling and efforts to measure alerting performance. resilience Issues related to Platform resilience in terms of scale, performance & backwards compatibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

4 participants