Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use url.format instead of kbn.eval where appropriate #10199

Closed
cjcenizal opened this issue Feb 6, 2017 · 0 comments
Closed

Use url.format instead of kbn.eval where appropriate #10199

cjcenizal opened this issue Feb 6, 2017 · 0 comments
Labels
chore stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Feb 6, 2017 •
edited by stacey-gammon
Loading

From #9605 (comment) (@spalger):

...dynamically creating urls with string concatenation is a recipe for hard to trace bugs. Ideally we would always use a bonafide formatter like url.format().

More background here: #20241 (comment)
@cjcenizal cjcenizal mentioned this issue Feb 6, 2017
Merged
12 tasks
@stacey-gammon stacey-gammon mentioned this issue Jun 26, 2018
Closed
@stacey-gammon stacey-gammon changed the title Use url.format to build URLs in Visualize wizard. Use url.format instead of kbn.eval where appropriate Jul 11, 2018
@stacey-gammon stacey-gammon added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Sharing labels Jul 11, 2018
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use kbn eval instead of string concatenation for creating URLs stacey-gammon/kibana
3 participants
@cjcenizal @joshdover @stacey-gammon