Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tag Management] Assignment list in flyout has double checkmarks #103148

Closed
cchaos opened this issue Jun 23, 2021 · 5 comments
Closed

[Tag Management] Assignment list in flyout has double checkmarks #103148

cchaos opened this issue Jun 23, 2021 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Object Tagging Saved Objects Tagging feature Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 23, 2021

Kibana version: Master

Screen Shot 2021-06-23 at 13 47 56 PM
@cchaos cchaos added bug Fixes for quality problems that affect the customer experience Feature:Saved Object Tagging Saved Objects Tagging feature labels Jun 23, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 23, 2021
@joshdover joshdover added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 23, 2021
@pgayvallet
Copy link
Contributor

pgayvallet commented Jun 24, 2021 •
edited
Loading

@cchaos we need to hide the default icons of the EuiSelectable component to use our custom 3-state check column instead

This was previously possible by using the showIcons: false option of EuiSelectableOption:

kibana/x-pack/plugins/saved_objects_tagging/public/components/assign_flyout/components/result_list.tsx

Line 48 in 4584a8b

showIcons: false,

However it seems this showIcons option is no longer present on EuiSelectableOptionBase

Do you know how we could retrieve the previous behavior?

FWIW, we need this custom 3-state 'column' to display partial assignment when assigning multiple tags at once:

Screenshot 2021-06-24 at 10 11 29

@pgayvallet pgayvallet added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jun 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@cchaos cchaos mentioned this issue Jun 24, 2021
Merged
2 tasks
@cchaos
Copy link
Contributor Author

cchaos commented Jul 12, 2021

@pgayvallet Can you double-check that this was fixed in master with the most recent upgrade of EUI?

@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 13, 2021 •
edited
Loading

@cchaos confirming that this is fixed on master, thank you.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Object Tagging Saved Objects Tagging feature Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cchaos @pgayvallet @joshdover @elasticmachine