Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Show chart starts a new search session #104330

Closed
lizozom opened this issue Jul 5, 2021 · 3 comments
Closed

[Search Sessions] Show chart starts a new search session #104330

lizozom opened this issue Jul 5, 2021 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Jul 5, 2021

  1. Go to Discover
  2. Save a search session that has some data.
  3. Click hide chart
  4. Session stays the same
  5. Click show chart
  6. New session starts

Expected result: session should stay the same

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:AppServices v7.15.0 labels Jul 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lizozom lizozom added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 5, 2021
@flash1293
Copy link
Contributor

I'm not sure whether this is a bug or not - showing the chart actually changes the query (adding a date histogram aggregation)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 8, 2021
@timroes
Copy link
Contributor

timroes commented Jul 14, 2021

I agree with Joe. We need to fetch different data for the chart than we need for the documents. We're also about to split those queries completely apart. So I think this is correct behavior since we're switching the queries that should be done. Closing this for now, but please feel to reopen in case I've missunderstood how search sessions should be working in this case.

@timroes timroes closed this as completed Jul 14, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants