Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened url documents do not get removed from kibana index when dashboard is deleted #10450

Closed
ppf2 opened this issue Feb 17, 2017 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@ppf2
Copy link
Member

ppf2 commented Feb 17, 2017

It looks like shortened url documents are added to the .kibana index when it is requested, but these url documents remain in the index forever - even if the parent dashboard is deleted from Kibana. Should there be some kind of cleanup mechanism?

Applies to other objects like Saved Search and Visualization as well.

@tbragin
Copy link
Contributor

tbragin commented Feb 18, 2017

@stacey-gammon @kobelb that seems more like a bug to me, what do you think?

@tbragin tbragin added bug Fixes for quality problems that affect the customer experience and removed release_note:enhancement labels Feb 18, 2017
@kobelb kobelb added the P3 label Feb 21, 2017
@ppf2
Copy link
Member Author

ppf2 commented Feb 22, 2017

One thing to be aware of if we decide to implement this:

We also allow shortened urls to be generated without saving objects (and we have users who are using this feature) - meaning that they will run a query from Discover, then click on the share/shortened url link without saving it as a saved search. This also will generate a URL document into the kibana index.

This means we will also have to first skip all the url documents with urls that are not tied to any object type, and for the ones with urls that are tied to an object, check to see if that object still exists, if not, delete the url document. And maybe also offer an interface where users can query the shortened urls not associated to objects and selectively delete the ones they no longer use, etc..

@stacey-gammon stacey-gammon removed the P3 label Apr 11, 2017
@stacey-gammon
Copy link
Contributor

It looks like with the current set up this won't be very simple fix. All that is stored in es is the original url and the urlId. In order to detect whether the url was generated from a saved object that no longer exists, you have to manually parse the url. This won't be efficient.

Moving forward, we should probably store the document id for the generated short url, so that it would be easier, and faster, to delete all short urls associated with it when the object itself is deleted. I'll investigate the effort involved in this.

It also sounds like we will need some kind of management section for this, since as you point out, some short urls are based off unsaved objects.

@stacey-gammon stacey-gammon added the Feature:Embedding Embedding content via iFrame label May 26, 2017
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 14, 2018
@timroes timroes added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@stacey-gammon stacey-gammon mentioned this issue Jan 5, 2021
13 tasks
@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Mar 2, 2021
@alexPolisevschi
Copy link

Is there an update on this? I see the issue is opened in 2017.
I had a request today to delete a shortened URL in production, from one of our Kibana users.

@ThomThomson ThomThomson added loe:x-large Extra Large Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated labels Oct 29, 2021
@ThomThomson ThomThomson removed their assignment Feb 6, 2023
@ThomThomson
Copy link
Contributor

I'm not sure if this is a problem that can be solved at the dashboard level. This is more of a problem with the saved objects service all together in that we aren't able to automatically clean up objects that are unused. A fix will need to be built universally.

I've reassigned to @elastic/appex-sharedux because I think this may fall under the umbrella of the content management initiative? If this is meant for a different team we can reassign, or if this is not a priority we can close.

@ThomThomson ThomThomson added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 6, 2023
@ThomThomson ThomThomson added Feature:Embeddables Relating to the Embeddable system and removed Feature:Embedding Embedding content via iFrame labels Jun 14, 2023
@vadimkibana
Copy link
Contributor

This is a potential feature, but currently there are no plans for implementing it.

@vadimkibana vadimkibana closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

9 participants