Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration test for rule params flattened type #104659

Open
mikecote opened this issue Jul 7, 2021 · 1 comment
Open

Add migration test for rule params flattened type #104659

mikecote opened this issue Jul 7, 2021 · 1 comment
Labels
estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) test-coverage issues & PRs for improving code test coverage

Comments

@mikecote
Copy link
Contributor

mikecote commented Jul 7, 2021

Starting in 7.13, we added the capability to filter rule params by changing the mapping to flattened (#92036). We have afterwards uncovered that rules that had params with long string values would fail the migration (#100607). Therefore, we should add a migration test for this scenario to ensure the migration always runs successfully in that scenario.
@mikecote mikecote added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Jul 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris added loe:large Large Level of Effort test-coverage issues & PRs for improving code test coverage migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility labels Aug 11, 2021
@gmmorris gmmorris added the estimate:medium Medium Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:large Large Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) test-coverage issues & PRs for improving code test coverage
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gmmorris @kobelb @mikecote @elasticmachine