Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI credentials for FullStory integration tests #105454

Closed
joshdover opened this issue Jul 13, 2021 · 1 comment · Fixed by #105794
Closed

Add CI credentials for FullStory integration tests #105454

joshdover opened this issue Jul 13, 2021 · 1 comment · Fixed by #105794
Assignees
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

In #102390 we added an integration test that is not currently enabled in CI. To get this enabled we need to:

  • Get the appropriate credentials populated into the FULLSTORY_ORG_ID and FULLSTORY_API_KEY env vars on Jenkins
  • Add x-pack/test/cloud_integration/config.ts to one of the functional test scripts that are executed by Jenkins in test/scripts/*.sh
  • Verify that the test gets run by inspecting the JUnit output in a CI run
@joshdover joshdover added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 13, 2021
@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Jul 13, 2021

The ops team responded that we need to export the needed env vars from src/dev/ci_setup/setup_env.sh. The file already reads the injected vars from Vault.

Other env vars are read from there in https://github.com/elastic/kibana/blob/master/src/dev/ci_setup/load_env_keys.sh. I think that file also needs updating.

I've created an issue to add the vars to Vault with infra but they said that the @elastic/kibana-operations should be able to help out with adding these to the Vault. @spalger thanks for offering to add those once the final values are confirmed with the Cloud folks!

cc @joshdover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants