-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Switch to SavedObjectClient.resolve #105808
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
Maybe a silly question: is there any reason that |
There was no logical reason. This type is already rather old, most likely we didn't have the |
In case anyone is following this issue but not the linked meta-issue (#100489): I published the Sharing Saved Objects developer guide, please take a look before proceeding with the implementation. And of course, please reach out if you run into any problems! Note that there are a few more steps than just switching to use |
There's this tiny PR that should be included in this task so I'll reopen this issue. |
We need to switch over to
SavedObjectClient.resolve
instead of.get
in the 8.0 release. This issue tracks work for thelens
andlens-ui-telemetry
saved object loading.This issue will also track progress for making Lens Saved Object share-capable. It has currently
nameSpaceType: single
.It should be updated to
multiple_isolated
.We could still consider switching over the lens telemetry to the (not so) new ui metric system which would help us get rid of the
lens-ui-telemetry
saved object instead.For more details see #100489
UPDATE about telemetry object: We never access this
lens-ui-telemetry
via saved object client (only write it that way), and always load it through ES client directly against the .kibana index and aggregate over those saved objects. It will eventually be fully removed along with the whole Lens telemetry system and replaced with uiMetrics system. After talking to @jportner: as we plan to remove it eventually, so let's leave it as it is for now. It won't generate aliases anyway and it won't cause any problems.The text was updated successfully, but these errors were encountered: