Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Make Dashboard Saved Object share-capable #105967

Closed
crob611 opened this issue Jul 16, 2021 · 5 comments · Fixed by #115817
Closed

[Dashboard] Make Dashboard Saved Object share-capable #105967

crob611 opened this issue Jul 16, 2021 · 5 comments · Fixed by #115817
Assignees
Labels
Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@crob611
Copy link
Contributor

crob611 commented Jul 16, 2021

Dashboard Saved Object is currently nameSpaceType: single. It should be updated to multiple_isolated per #100489

@crob611 crob611 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jul 16, 2021
@crob611 crob611 self-assigned this Jul 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jportner
Copy link
Contributor

Note that this also entails changing the client and server API calls to use the new savedObjectsClient.resolve() API (instead of savedObjectsClient.get()), and handle the three different outcomes ('exactMatch', 'aliasMatch', and 'conflict'). See more details in the linked meta issue #100489.

@jportner
Copy link
Contributor

In case anyone is following this issue but not the linked meta-issue (#100489):

I published the Sharing Saved Objects developer guide, please take a look before proceeding with the implementation. And of course, please reach out if you run into any problems!

@jportner
Copy link
Contributor

@crob611 just to let you know, making this change will cause Spaces API integration tests to fail. The same thing is happening for index patterns, see here: #114408 (comment)

When you get a PR up for making dashboards share-capable, tag me and I will push a commit that fixes the integration tests for you 👍

@jportner
Copy link
Contributor

Hey @crob611 I just wanted to check on the status of this to see if it's on track for the 8.0 release; as mentioned above, I suspect the change will cause some Spaces integration tests to start failing, and I'll need to help you fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants