Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Management API integration test coverage #106168

Closed
cjcenizal opened this issue Jul 19, 2021 · 2 comments
Closed

Index Management API integration test coverage #106168

cjcenizal opened this issue Jul 19, 2021 · 2 comments
Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration tests_needed

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 19, 2021

This was generated as an output of #105863.

Note that some routes contain nuanced behavior, which I've described in the "Route notes" column. I assessed tests for error states as well. Generally, route error states aren't covered by our tests.

Legend

✅ - Tests are comprehensive
🔧 - Some functionality isn't tested
🚫 - Test is missing

Route coverage

Component templates

Route Route notes API test / error Test notes
Create component template Collision check ✅ 🚫
Delete component template Split on comma ✅ ✅
Get all component templates ✅ 🚫
Get one component template ✅ 🚫
Component template privileges Test is sparse, made up for by unit tests ✅ 🚫 We should test a user with cluster: { manage_index_templates: false } and verify they can't access the UI
Update component template ✅ ✅

Data streams

Route Route notes API test / error Test notes
Delete data stream(s) 🔧 🚫
Get all data streams Include stats option ✅ 🚫
Get one data stream Include stats option 🔧 🚫

Indices

Route Route notes API test / error Test notes
Clear cache Bulk ✅ 🚫
Close Bulk 🔧 🚫
Delete Bulk 🔧 🚫
Flush Bulk 🔧 🚫
Force merge Bulk, maxNumSegments option 🔧 🚫
Freeze Bulk, encodeURIComponent 🔧 🚫
List Bulk, enrich, encodeURIComponent ✅ 🚫
Open Bulk 🔧 🚫
Refresh Bulk 🔧 🚫
Reload Bulk, enrich, encodeURIComponent ✅ 🚫
Unfreeze Bulk, encodeURIComponent 🔧 🚫

Mapping

Route Route notes API test / error Test notes
Get mapping ✅ 🚫

Settings

Route Route notes API test / error Test notes
Load settings ✅ 🚫
Update settings ✅ 🚫

Stats

Route Route notes API test / error Test notes
Get stats ✅ 🚫

Index templates

Route Route notes API test / error Test notes
Create index template Collision check, legacy option 🔧 ✅
Delete index template Bulk, legacy option 🔧 🚫
Get all index templates Cloud-managed, includes legacy 🔧 🚫
Get one index template Cloud-managed, legacy option 🔧 🚫
Simulate 🚫 🚫
Update index template Exist check, legacy option 🔧 ✅
@cjcenizal cjcenizal added tests_needed chore Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration labels Jul 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech
Copy link
Contributor

Closing this issue: the team improved the api integration test coverage during a recent testing spike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration tests_needed
Projects
None yet
Development

No branches or pull requests

3 participants