Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][Observability] Alerts table: fullscreen feature does not work as expected #108174

Closed
katrin-freihofner opened this issue Aug 11, 2021 · 4 comments · Fixed by #108746
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Aug 11, 2021

Kibana version:
Edge cluster

When in fullscreen mode, the flyout does not appear as expected (see video below.)

Expected behavior:
The flyout should be aligned with the table. The backdrop should cover the whole page.

I suggest removing the fullscreen feature for 7.15

Screenshots (if relevant):
fullscreen-feature

cc @mgiota

@katrin-freihofner katrin-freihofner added the bug Fixes for quality problems that affect the customer experience label Aug 11, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 11, 2021
@katrin-freihofner katrin-freihofner added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 11, 2021
@mgiota mgiota self-assigned this Aug 16, 2021
@mgiota
Copy link
Contributor

mgiota commented Aug 16, 2021

While testing this issue in my current branch, I noticed that Reason field is not clickable. I update now from master to verify that on master reason field is clickable to be able to test it.

UPDATE: it was a problem of my branch. Reason field is clickable on master

@mgiota
Copy link
Contributor

mgiota commented Aug 16, 2021

I fixed the issue, but after I updated from master I tested it again and looks like the full screen functionality doesn't work anymore.

full_screen_broke.mov

@kqualters-elastic @michaelolo24 Did anything change regarding fullscreen functionality? If it is broken, easiest would be to simply hide it. It there a simple way to do so?

@mgiota
Copy link
Contributor

mgiota commented Aug 17, 2021

This PR #108781 fixed the broken Full screen functionality.

@katrin-freihofner Feature now works as expected. It was easier to fix it, than searching how to hide the Full screen button that comes with EuiDataGrid
https://user-images.githubusercontent.com/2852703/129686876-d0645167-ac25-4c04-89dc-d7fcd13b1b74.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants