Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use savedObjectsClient.resolve for retrieving index patterns #108335

Closed
ppisljar opened this issue Aug 12, 2021 · 1 comment · Fixed by #108637
Closed

use savedObjectsClient.resolve for retrieving index patterns #108335

ppisljar opened this issue Aug 12, 2021 · 1 comment · Fixed by #108637
Assignees
@mattkime
Labels
blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. v8.0.0

Comments

@ppisljar
Copy link
Member

index patterns service should use savedObjectsClinent.resolve instead get to retrieve the saved object.

It should handle an exactMatch and an alias as a hit and return the corresponding saved object, and a conflict as an error and will just throw.
@ppisljar ppisljar added blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. Team:AppServices v8.0.0 labels Aug 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime mentioned this issue Aug 15, 2021
Merged
@mattkime mattkime self-assigned this Aug 16, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Aug 16, 2021
@jportner jportner mentioned this issue Aug 24, 2021
Closed
@jportner jportner mentioned this issue Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data views - saved object client use resolve instead of get mattkime/kibana
3 participants
@mattkime @ppisljar @elasticmachine