Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Reenable skipped cypress tests #109038

Closed
dplumlee opened this issue Aug 18, 2021 · 5 comments
Closed

[Security Solution] Reenable skipped cypress tests #109038

dplumlee opened this issue Aug 18, 2021 · 5 comments
Assignees
@MadameSheema
Labels
bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed

Comments

@dplumlee
Copy link
Contributor

The header/navigation.spec.ts file was skipped in this pr due to flakiness in order to get things merged, it needs to be fixed and reenabled.

First glance, it looks to be not getting reset properly to kibana home for the 2nd batch of tests in the file
@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team triage_needed labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema mentioned this issue Aug 18, 2021
Merged
1 task
@dplumlee
Copy link
Contributor Author

problem has been fixed by @marshallmain with this pr #108922. Just need to unskip the tests now

@MadameSheema
Copy link
Member

@dplumlee @marshallmain I'm working to bring back cypress tests: #109129 so I can take care of it in that PR :)

@MadameSheema MadameSheema self-assigned this Aug 19, 2021
@MadameSheema
Copy link
Member

MadameSheema commented Aug 19, 2021 •
edited
Loading

Test re-enabled on #109129 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadameSheema MadameSheema

Labels
bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elasticmachine @MadameSheema @dplumlee