Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saved objects bulkResolve API #111201

Closed
jportner opened this issue Sep 3, 2021 · 1 comment · Fixed by #112025
Closed

Add saved objects bulkResolve API #111201

jportner opened this issue Sep 3, 2021 · 1 comment · Fixed by #112025
Assignees
Labels
enhancement New value added to drive a business result Feature:Saved Objects Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

jportner commented Sep 3, 2021

Originally when we implemented SavedObjectsClient.resolve, we envisioned it to be used only in precise cases where a "deep link" URL is used. However, we recently discovered that initially, the usage of resolve will be more widespread than anticipated:

The client-side SavedObjectsClient silently takes get calls and batches them into bulkGet for performance reasons; this allows a Kibana page to load without making dozens or hundreds of separate HTTP calls to load all of the data that it needs.

Based on the two linked issues above, if we don't do the same for resolve, it could result in a very negative performance impact and/or cause Kibana pages to stop functioning entirely if the maximum open request limit is exceeded.

With that in mind, we need to:

  1. Create a bulkResolve API, and
  2. Change the client-side implementation to batch resolve calls into bulkResolve
@jportner jportner added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Saved Objects labels Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner jportner self-assigned this Sep 3, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 10, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 28, 2021
@jportner jportner added the Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature label Oct 27, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants