Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporting needs to use savedObjectsClient.resolve when retrieving saved objects #112565

Closed
ppisljar opened this issue Sep 20, 2021 · 1 comment · Fixed by #113641
Closed

reporting needs to use savedObjectsClient.resolve when retrieving saved objects #112565

ppisljar opened this issue Sep 20, 2021 · 1 comment · Fixed by #113641
Labels
blocker (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort v8.0.0

Comments

@ppisljar
Copy link
Member

as part of #100489

reporting should make sure it uses .resolve instead .get when saved object id its retrieving didn't come from saved object but from url user could bookmark in the past.

https://github.com/elastic/kibana/blob/master/x-pack/plugins/reporting/server/export_types/csv/create_job.ts#L24
https://github.com/elastic/kibana/blob/master/x-pack/plugins/reporting/server/export_types/printable_pdf/create_job/compatibility_shim.ts#L20-L27
@ppisljar ppisljar added blocker (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:AppServices labels Sep 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Sep 20, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 27, 2021
@jportner jportner mentioned this issue Sep 30, 2021
Closed
@dokmic dokmic mentioned this issue Oct 1, 2021
Merged
1 task
@jportner jportner mentioned this issue Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Use updated saved object resolver dokmic/kibana
2 participants
@ppisljar @elasticmachine