Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] should log queries when inspect queries is turned on #112655

Closed
shahzad31 opened this issue Sep 21, 2021 · 7 comments · Fixed by #115170
Closed

[Uptime] should log queries when inspect queries is turned on #112655

shahzad31 opened this issue Sep 21, 2021 · 7 comments · Fixed by #115170
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0

Comments

@shahzad31
Copy link
Contributor

shahzad31 commented Sep 21, 2021

Kibana version:
master

When users turns on the inspect queries in observability section of kibana advanced settings,

uptime should logs queries in kibana logs
currenty uptime uses flag from session storage to get those query logs

ACs:

  • Remove the sessionStorage.set('uptime_debug', true); configuration option
  • Use the configuration from:
    image
    • With this enabled, the queries will be logged as currently done with sessionStorage.set('uptime_debug', true);
@shahzad31 shahzad31 added the bug Fixes for quality problems that affect the customer experience label Sep 21, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 21, 2021
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 21, 2021
@shahzad31 shahzad31 added needs-team Issues missing a team label v7.16.0 labels Sep 21, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 21, 2021
@paulb-elastic
Copy link
Contributor

Is Uptime the only frontend that uses sessionStorage.set...?

Is the idea here, to change Uptime to ignore this setting (i.e. remove it), and just be triggered from the Observability setting in your screenshot, or to read from both (in which case, either could switch debug on)?

@andrewvc
Copy link
Contributor

Love standardizing this, I didn't realize we were different and burned quite a bit of time on this. Thanks for finding this @shahzad31 !

@paulb-elastic
Copy link
Contributor

Will this also implement the Inspect option like you've done for User Experience in #113120?

@paulb-elastic
Copy link
Contributor

Updated the ACs as clarified in refinement

@dominiqueclarke
Copy link
Contributor

@shahzad31 I am seeing the inspect panel working as expected from Uptime, but the queries are not logged in Kibana logs. For User Experience, both the inspect panel appears and logs are available in Uptime. What is the expected behavior here?

@shahzad31
Copy link
Contributor Author

@shahzad31 I am seeing the inspect panel working as expected from Uptime, but the queries are not logged in Kibana logs. For User Experience, both the inspect panel appears and logs are available in Uptime. What is the expected behavior here?

@dominiqueclarke this is a regression, i have made a quick fix for the PR #117124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants