Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/CSV Export] Use points-in-time for paging through search responses #112865

Closed
tsullivan opened this issue Sep 22, 2021 · 4 comments
Closed
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result Feature:Reporting:CSV Reporting issues pertaining to CSV file export impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

tsullivan commented Sep 22, 2021

Points in Time

Goal: Reporting CSV Export uses _scroll as the search API in Elasticsearch for paging through the results.If the hits are sorted based on unique value(s), using Points-In-Time would be more optimal than using _scroll.

Challenge: paging through search responses using the point-in-time depends on having unique values for the sort keys, which is something the user might not be concerned with when creating a view in Discover. There is no way for Reporting to know if the search responses will have duplicate sort keys.

Here are some success scenarios where using PIT would be best:

  1. Works by default:
    • The user has a view in Discover where the hits are sorted based on their "time field", which has unique values
    • Each sort key is unique, as no records that have the same timestamp.
  2. Works by explicit user action:
    • The user has a view in Discover where the hits are sorted based on their "time field", which aren't unique
    • They click a 2nd field to sort by, which is unique per-timestamp in its values
    • Each sort key is unique, as no records have the same combination of timestamp-and-other-field.

To solve the goal, Reporting needs a way to know if the request fits a success scenario for PIT.

@tsullivan tsullivan added the enhancement New value added to drive a business result label Sep 22, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 22, 2021
@tsullivan tsullivan added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:AppServices labels Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 22, 2021
@tsullivan tsullivan changed the title [Reporting/CSV Export] Use PIT for paging through search responses [Reporting/CSV Export] Use points-in-time for paging through search responses Sep 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 22, 2021
@lukasolson
Copy link
Member

Related: #80406

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:large Large Level of Effort labels Jun 3, 2022
@tsullivan
Copy link
Member Author

I'm closing this issue for now, as there doesn't seem to be a way to reliable know when we can use PIT for search vs scan-and-scroll, since the data source is the user's. We can always re-open this issue if a way forward appears.

@sophiec20 sophiec20 added the Feature:Reporting:CSV Reporting issues pertaining to CSV file export label Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
@sophiec20 sophiec20 added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result Feature:Reporting:CSV Reporting issues pertaining to CSV file export impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

4 participants