Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add Test coverage for preconfiguration variable override logic. #113248

Closed
kpollich opened this issue Sep 28, 2021 · 1 comment · Fixed by #113270
Closed

[Fleet] Add Test coverage for preconfiguration variable override logic. #113248

kpollich opened this issue Sep 28, 2021 · 1 comment · Fixed by #113270
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@kpollich
Copy link
Member

Ref #113204
Ref elastic/fleet-server#742

Add automated test coverage for Fleet's preconfiguration and package_policy services that validates our variable overriding logic during setup.

The code path we need to hit is here, in our addPreconfiguredPolicyPackages method:

await addPackageToAgentPolicy(
soClient,
esClient,
installedPackage,
agentPolicy,
defaultOutput,
name,
description,
(policy) => overridePackageInputs(policy, packageInfo, inputs)
);

We should also add functional tests in the fleet_api_integration test project for the PUT /api/fleet/setup/preconfiguration API endpoint.

@kpollich kpollich added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants