Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Convert files in server/routes/setup, ui.js to typescript #117764

Closed
Tracked by #117729
, #127224
...
neptunian opened this issue Nov 5, 2021 · 1 comment · Fixed by #131265
Closed
Tracked by #117729
, #127224
...

[Stack Monitoring] Convert files in server/routes/setup, ui.js to typescript #117764

neptunian opened this issue Nov 5, 2021 · 1 comment · Fixed by #131265
Assignees
@weltenwort
Labels
Epic: Stack Monitoring TypeScript Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@neptunian
Copy link
Contributor

neptunian commented Nov 5, 2021 •
edited by Kerry350
Loading

Convert files/code in server/routes/api/v1/setup and server/routes/api/v1/ui.js and to typescript

io-ts should also be used for route validation, e.g.: https://github.com/elastic/kibana/blob/main/x-pack/plugins/monitoring/server/routes/api/v1/apm/instance.ts#L26
@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Epic: Stack Monitoring TypeScript labels Nov 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@neptunian neptunian mentioned this issue Nov 5, 2021
Closed
10 tasks
@jasonrhodes jasonrhodes mentioned this issue Mar 9, 2022
Closed
39 tasks
@weltenwort weltenwort self-assigned this Apr 21, 2022
@weltenwort weltenwort mentioned this issue Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
Epic: Stack Monitoring TypeScript Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Stack Monitoring] Convert setup routes to TypeScript weltenwort/kibana
3 participants
@weltenwort @neptunian @elasticmachine