Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Item URL does encode Item URL #119733

Closed
dej611 opened this issue Nov 25, 2021 · 4 comments
Closed

[TSVB] Item URL does encode Item URL #119733

dej611 opened this issue Nov 25, 2021 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure :VisEditors:fix-it-week

Comments

@dej611
Copy link
Contributor

dej611 commented Nov 25, 2021

Describe the bug:

The current TSVB Item URL drilldown does not offer any ability (neither automatic, or manual) to encode URLs and handle special characters.

In dashboard drilldowns there's an option to opt-in the encoding, since #84650 .

Steps to reproduce:

  1. Create a runtime field SpecialField as emit("Blue & Green");
  2. Open TSVB and create a Table, add the SpecialField
  3. Add the Item URL as : http://www.google.com/search?q={{key}}
  4. Click on Blue & Green in the table to see that only "Blue" has been searched because the URL is not encoded

Expected behavior:

Auto-encoding of the URL, or perhaps offer an option to encode when necessary.

@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@dej611
Copy link
Contributor Author

dej611 commented Nov 25, 2021

Just found a similar issue #24233

@Dosant
Copy link
Contributor

Dosant commented Nov 25, 2021

Just for reference, this is what we did in the dashboard URL drilldown: #86902

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Nov 25, 2021
@flash1293
Copy link
Contributor

Duplicate of #24233

@flash1293 flash1293 marked this as a duplicate of #24233 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure :VisEditors:fix-it-week
Projects
None yet
Development

No branches or pull requests

5 participants