Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Architecture discussion: Implicit or explicit source configuration selection #119887

Closed
weltenwort opened this issue Nov 29, 2021 · 1 comment
Assignees
Labels
discuss Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Nov 29, 2021

Currently, the Logs UI (and the Metrics UI) implicitly use the default source configuration. This works because...

  1. there are defaults for all values even no user saved any source configuration before and
  2. there is no ambiguity because there is only one per space.

When we introduce a way to manage and switch between multiple source configurations we need to decide what the user will be shown when visiting the Logs UI. Among the possible variants are:

  1. Always explicit choice: When the user visits the Logs UI they always have to choose which source configuration to show. When no source configuration exists they have to create one first. Subsequent changes to the source configuration are unambiguously written to the existing source configuration.
  2. Explicit choice on first visit: As variant 1 above, but the id of the last visited source configuration is stored locally and restored when the user visits again. An explicit selection of a source configuration is therefore only needed for the first visit or when the user intends to switch to a different source configuration. This is similar to the Kibana dashboard workflow.
  3. Implicit choice: As variant 2 above, but without the need for the user to select a source configuration even on first visit. This adds the requirement that there always has to be a "default" source configuration that is chosen when no explicit choice is made or no previous choice can be restored. It is unclear how subsequent changes to such an implicit "default" source configuration are persisted. This interacts with "transient or persistent" architecture choice presented further below.

image

@weltenwort weltenwort added discuss Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 29, 2021
@weltenwort weltenwort self-assigned this Nov 29, 2021
@weltenwort weltenwort changed the title [Infra UI] Architecture discussion: Implicit or explicit [Infra UI] Architecture discussion: Implicit or explicit source configuration selection Nov 29, 2021
@weltenwort
Copy link
Member Author

merged into #120932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

1 participant