Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Alerts] Create common type for dot notation fields #122405

Open
Tracked by #165878
dplumlee opened this issue Jan 5, 2022 · 3 comments
Open
Tracked by #165878
Assignees
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@dplumlee
Copy link
Contributor

dplumlee commented Jan 5, 2022

With the new addition of dot notation fields in the RAC initiative, we are finding a lot of bugs created by our code's assumption of nested notations for all fields. There is currently no uniform way to handle these new types and we need to create some shared method of Typing code between the front end and back end to make it easier for devs to navigate the new field names

Temporary type changes have been made in certain PRs already that will need to be converted to a more permanent solution when finished

@dplumlee dplumlee added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team labels Jan 5, 2022
@dplumlee dplumlee self-assigned this Jan 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dhurley14
Copy link
Contributor

I think this might be an example of something where the type interpreted by typescript doesn't match with what is defined in the non-flattened version https://github.com/elastic/kibana/pull/123324/files#r787241301

@marshallmain marshallmain added 8.2 candidate considered, but not committed, for 8.2 release and removed 8.1 candidate labels Feb 9, 2022
@MindyRS MindyRS added the Team:Detections and Resp Security Detection Response Team label Feb 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@peluja1012 peluja1012 added technical debt Improvement of the software architecture and operational architecture 8.3 candidate labels Mar 24, 2022
@marshallmain marshallmain removed the 8.2 candidate considered, but not committed, for 8.2 release label Mar 31, 2022
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Detection Alerts Security Detection Alerts Area Team labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

7 participants