Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSLint/ESLint in the new platform #12470

Closed
kimjoar opened this issue Jun 22, 2017 · 1 comment
Closed

TSLint/ESLint in the new platform #12470

kimjoar opened this issue Jun 22, 2017 · 1 comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Jun 22, 2017

We need to explore TSLint and/or ESLint in the context of the new platform, e.g. we must fail when trying to import outside any plugins directory.

Things to potentially explore:

  • TSLint vs ESLint? I expect TSLint can give us TypeScript specific errors, but maybe ESLint is enough? Should do some testing
  • We should consider disallowing any use of process within Kibana. It feels like that should only happen in the CLI, e.g. no process.exit etc within Kibana itself.
@kimjoar kimjoar added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 22, 2017
@epixa
Copy link
Contributor

epixa commented May 4, 2018

I'm going to close this for now. It's a good idea, but we should create specific issues for specific rules/changes rather than having a generic issue without a concrete "end".

@epixa epixa closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants