Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Read User for Security able to update Alert Status #126331

Open
ghost opened this issue Feb 24, 2022 · 10 comments
Open

[Security Solution]Read User for Security able to update Alert Status #126331

ghost opened this issue Feb 24, 2022 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@ghost
Copy link

ghost commented Feb 24, 2022

Describe the bug
Read User for Security able to update Alert Status

Build Details

Version: 8.1.0-BC3
Commit:0335dd6a26ef29ae9021d0fae9347dc88f3b7d6e
Build:50346

Pre-Condition

  • Create a 8.1.0 BC3 Released Build
  • Create Custom User and Assign custom Role to it
  • Role Configuration
    • Elasticsearch Privilege

image

  • Kibana Privilege

image

Steps

  • Login with above create user
  • Attach the Alert to Case and make sure sync should be enable in the case
  • Change the case status that will update the alert status
  • Observed that by above operation read user is able to update the alert status

Additional Observation

  • User with Read Privilege to Case app
    • Functionality of Case get changes to read access on whole app where there is interaction of case like attach alert to case or say attach timeline to case

Expected Result
User should not able to update alert status from case with read Privilege

Screen-Cast

update-alert-status.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 24, 2022
@manishgupta-qasource
Copy link

Reviewed & assigned to @MadameSheema

@MadameSheema MadameSheema added the Team:Detections and Resp Security Detection Response Team label Feb 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema added the Team:Security Solution Platform Security Solution Platform Team label Feb 28, 2022
@yctercero
Copy link
Contributor

@karanbirsingh-qasource is this present in earlier releases too? Trying to figure out how all these read only issues came about or if they've all been there for a while. Thanks so much for the testing!

@ghost
Copy link
Author

ghost commented Mar 2, 2022

sure @yctercero we can check the issue behavior earlier releases and it is occuring on all the previous releases

Observations

Release Issue Status Kibana privilege
8.1.0 Issue Occurring ❌    image
8.0.1 Issue Occurring ❌    image
8.0.0 Issue Occurring ❌  image
7.17.0 Issue Occurring ❌   image
7.16.0 Issue Occurring ❌ image
7.15.0  Issue Occurring ❌  image

Please let me known if any other checkpoint to check for this issue.

thanks !!

@yctercero
Copy link
Contributor

I reached out to the RAC team about this as it has to do with how they implemented this feature within cases. It looks like this behavior was documented here - #102929

This might be partly a product question. I assume that someone who is assigned read only in "Security" and all in "Cases" is meant to just be working everything having to do with cases. Not sure how affective their role would be if they can't update the alert status, but based on the Kibana privileges it doesn't make sense that they are able to update the alert status in the case.

If a user with read only in "Security" should not be able to update the alert from the case, I would just hide that feature all together.

Any feedback here @MikePaquette @jethr0null ? (not sure who is the cases PM)

@yctercero yctercero added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed triage_needed labels Mar 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@yctercero yctercero assigned cnasikas and unassigned yctercero Mar 8, 2022
@yctercero yctercero added Feature:Cases Cases feature and removed Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team labels Mar 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kobelb
Copy link
Contributor

kobelb commented Mar 8, 2022

This is occurring because the user has write privileges to the .alerts-security.alerts-default indices. It was my understanding that we wanted to be respecting the user's Elasticsearch privileges when reading and writing the security solution alerts.

If you all would like for us to change it so that it doesn't matter whether the user has write privileges to the .alerts-security.alerts-* indices and instead use whether the user has all access to the "Security" Kibana feature to make this determination, we can do so. It'll make our code and implementations more consistent and easier to reason about going forward.

@cnasikas
Copy link
Member

cnasikas commented Mar 9, 2022

If you all would like for us to change it so that it doesn't matter whether the user has write privileges to the .alerts-security.alerts-* indices and instead use whether the user has all access to the "Security" Kibana feature to make this determination, we can do so. It'll make our code and implementations more consistent and easier to reason about going forward.

This will also come into alignment with what the Security solution does in the alerts table. If you have read permissions to Security Solution, you cannot change the status of an alert from the table (they hide the context menu item). If you have all you can. Although, I test it and the API seems to not respect the privileges when updating the status of an alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

6 participants