Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Evaluate impact of moving to package semver instead of release tag in labeling #126348

Closed
juliaElastic opened this issue Feb 24, 2022 · 3 comments
Assignees
Labels
discuss Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@juliaElastic
Copy link
Contributor

juliaElastic commented Feb 24, 2022

Evaluate impact of Add support for pre-release semver in packages package-spec#225 on kibana/fleet.

Changes:

  • release label in packages is deprecated (still populated for BWC)
  • semantic versioning is used to determine if package is stable/prerelease
  • no change in registries for now (snapshot, staging, production)

Required changes on Fleet side: #122973

  • Change experimental=true to prerelease=true in registry API calls
  • Update UI labeling to be based on semver instead of release label of packages
  • Potentially introduce UI toggle to show/hide prerelease packages

Open questions:

What is the impact on older versions of Kibana?
What is the business impact? (Keep as tech debt vs fixing)
What is the migration path from deprecation of release field -> removal?
Impact on Beta/Experimental/etc labeling in Integrations UI and switching between Beats/Elastic Agent view.

@juliaElastic juliaElastic added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 24, 2022
@juliaElastic juliaElastic self-assigned this Feb 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor Author

juliaElastic commented Feb 24, 2022

Findings:

1. What is the impact on older versions of Kibana?

2. What is the business impact? (Keep as tech debt vs fixing)

3. What is the migration path from deprecation of release field -> removal?

4. Impact on Beta/Experimental/etc labeling in Integrations UI and switching between Beats/Elastic Agent view.

5. Risk of kibana auto/manual upgrade to prerelease packages
It can happen today also if there is a prerelease package published to prod registry.
Kibana UI auto upgrades to latest package version for some packages e.g. apm-8.2.0-dev3
Kibana UI shows upgrade button if there is a newer package available (even if that package is non GA)
Ideas to improve the situation:

  • Do not auto upgrade to prerelease
  • Confirmation window for manual upgrade
  • UI Toggle to hide prerelease packages

Note: currently Registry.findLatestPackage includes experimental=true flag always, this should be toggled as well when the UI toggle is implemented:

async function _fetchFindLatestPackage(
packageName: string,
options?: FetchFindLatestPackageOptions
) {
const { ignoreConstraints = false } = options ?? {};
const registryUrl = getRegistryUrl();
const url = new URL(`${registryUrl}/search?package=${packageName}&experimental=true`);

@juliaElastic
Copy link
Contributor Author

Shared findings with fleet-team on the engineering sync on March 22. Updated with suggested change in Beats/Elastic Agent toggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

2 participants