Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Support query languages #127252

Closed
stratoula opened this issue Mar 9, 2022 · 3 comments
Closed

[Discover] Support query languages #127252

stratoula opened this issue Mar 9, 2022 · 3 comments
Assignees
Labels
Feature:Discover Discover Application Feature:Unified search Unified search related tasks Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@stratoula
Copy link
Contributor

stratoula commented Mar 9, 2022

Describe the feature:
Exactly as described here, we would like to support text-based languages in discover. At the moment, a user can select a dataview/saved search and interact with the fields list.

We want to enhance the dataview picker (part of the unified search project) to give the users the ability to select a text-based language. The search bar is going to be replaced by a code editor (part of the unified_search component) and some other parts of the UI are going to be hidden as they might not make sense.

image

Discover will trigger a search via the “SearchSource” interface in case of KQL mode and use the search service with the sql strategy in case SQL mode. The data fetching will be part of the discover app while the unified search plugin will hold the current state.

Open questions

  • Do we want to integrate them with filter pills / time range picker? (or replace with SQL box?)
  • Design finalization
@stratoula stratoula added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Unified search Unified search related tasks labels Mar 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jun 28, 2022

Linking #134654 for visibility of @elastic/kibana-data-discovery efforts

@stratoula
Copy link
Contributor Author

I am closing this as this PR #136702 was merged in main and it contains the main functionality for supporting text-based languages in Discover. I have created a new issue for the follow-ups.#136950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Feature:Unified search Unified search related tasks Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants