Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requireJs urlArgs cache busting option commented out #1291

Closed
mrdavidlaing opened this issue Jun 10, 2014 · 3 comments
Closed

requireJs urlArgs cache busting option commented out #1291

mrdavidlaing opened this issue Jun 10, 2014 · 3 comments

Comments

@mrdavidlaing
Copy link
Contributor

I've been experiencing issues with Kibana upgrades failing because of browser caching - specifically in Chrome, the files loaded by requireJs continue to load old version from the browser cache.

I suspect this is because requireJs' urlArgs config setting is commented out in app/components/require.config.js

Is there any reason not to uncomment this?

@mrdavidlaing
Copy link
Contributor Author

Weirdly, the commit that added this feature did so with

  1. urlArgs commented out in src/app/components/require.config.js
  2. urlArgs present in dist/app/components/require.config.js

Looks like a bug which only surfaced when dist/ was removed from the repo

@mrdavidlaing
Copy link
Contributor Author

/cc @spenceralger

@spalger
Copy link
Contributor

spalger commented Oct 7, 2014

Looks like you solved this, sorry I never got you a response.

In Kibana 4 we will be introducing cache busting in BETA 2, follow #1574 for updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants