Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Alerting] Prevent search suggestions and rule flyout from being open simultaneously #131721

Closed
ryankeairns opened this issue May 6, 2022 · 3 comments · Fixed by #132108
Assignees
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented May 6, 2022

Screen Shot 2022-04-25 at 8 10 12 AM

Should we prompt to close/save the flyout when they click back in the main KQL bar
Otherwise, you see this overlapping of elements:

@ryankeairns
I think what we could do is, using the flyout to own focus and getting closed when clicked outside

Bildschirmfoto 2022-05-05 um 10 07 10

However, AFAIK we don't have currently access to the way it's being rendered, so it would need to be solved in a separate PR ... or being a feature request for our alerting efforts

Originally posted by @kertal in #130462 (comment)

@botelastic botelastic bot added the needs-team Issues missing a team label label May 6, 2022
@ryankeairns ryankeairns added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 6, 2022
@kertal
Copy link
Member

kertal commented May 9, 2022

A quick research, the flyout showing the rule to add would need to have ownFocus set to true

<EuiFlyout
onClose={checkForChangesAndCloseFlyout}
aria-labelledby="flyoutRuleAddTitle"
size="m"
maxWidth={620}
ownFocus={false}
>

However, I think this would need to be configurable, since there might be rules that prefer the "old" behavior

@kertal
Copy link
Member

kertal commented May 9, 2022

WDYT dear @elastic/response-ops, owners of this part of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
4 participants