Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Strongly type RRule in rule snooze SavedObjects #132164

Closed
Zacqary opened this issue May 12, 2022 · 1 comment · Fixed by #131019
Closed

[RAM] Strongly type RRule in rule snooze SavedObjects #132164

Zacqary opened this issue May 12, 2022 · 1 comment · Fixed by #131019
Assignees
@Zacqary
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0

Comments

@Zacqary
Copy link
Contributor

Zacqary commented May 12, 2022

As discussed in #131019 (comment)

Instead of storing rRule as a string in SavedObjects, duplicate the schema from the NPM rrule library. We can then parse this using the RRule() constructor function instead of rrulestr.
@Zacqary Zacqary added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.3.0 labels May 12, 2022
@Zacqary Zacqary self-assigned this May 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

This was referenced May 12, 2022
Merged
Open
@Zacqary Zacqary moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management May 17, 2022
@Zacqary Zacqary moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management May 17, 2022
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Rules & Alerts Management May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM] Add data model for scheduled and recurring snoozes Zacqary/kibana
2 participants
@Zacqary @elasticmachine