Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize base histogram styling #13335

Closed
snide opened this issue Aug 3, 2017 · 5 comments
Closed

Visualize base histogram styling #13335

snide opened this issue Aug 3, 2017 · 5 comments
Assignees
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent release_note:enhancement

Comments

@snide
Copy link
Contributor

snide commented Aug 3, 2017

The font used in K7 is roboto, but K6 uses open sans. My guess is you want to have this as a global variable (or inherited from somewhere) so you can flip this over.

image

@snide snide added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Aug 3, 2017
@ppisljar
Copy link
Member

ppisljar commented Aug 23, 2017

thanks @snide this is amazing. some additional things that come to mind:

  • dark theme: should we use the same colors for axes and labels when dark theme is enabled ?
  • what font sizes to use ?
  • axis title color and weight
  • dashed line ... 2 pixels empty and 2 pixels dash ?
  • end zone indicators

@snide
Copy link
Contributor Author

snide commented Aug 23, 2017

@ppisljar

  • Be nice if there was a variable / config file to adjust the color in code for light / dark. Those colors listed above would have matching dark counterparts
  • Axis title is 16px. The rest are 14px.
  • Axis title color is #000.
  • Correct on dashed line.

Question... what are end zone indicators?

@thomasneirynck thomasneirynck removed their assignment Aug 25, 2017
@ppisljar
Copy link
Member

setting fonts to 14 and 16px ... seems a bit bigger than in the image on top ?

screenshot-localhost-5601 2017-08-28 09-07-22

@ppisljar
Copy link
Member

end zones: the gray area on the begining and the end of the chart :
screenshot-localhost-5601 2017-08-28 09-14-38

@timroes
Copy link
Contributor

timroes commented Mar 12, 2018

This styling should all go into the new unified chart component developed in EUI (WIP PR: elastic/eui#309). Thus closing this issue here. Please move all discussion to this PR or issues in EUI.

@timroes timroes closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent release_note:enhancement
Projects
None yet
Development

No branches or pull requests

4 participants