Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add confirmation modal for destructive layer actions #135253

Closed
Tracked by #57706
MichaelMarcialis opened this issue Jun 27, 2022 · 2 comments · Fixed by #135707
Closed
Tracked by #57706

[Lens] Add confirmation modal for destructive layer actions #135253

MichaelMarcialis opened this issue Jun 27, 2022 · 2 comments · Fixed by #135707
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

Per a recent conversation with @yuvielastic, Lens currently doesn't ask for user confirmation when attempting to use destructive layer actions (i.e. clear and delete). As such, he found himself in a position where he accidentally cleared his desired layer configuration with no way to get it back (as it hadn't been saved yet). While undo/redo functionality would be most desirable (as mentioned by @flash1293) and help prevent such situations, that is not a solution we are able to implement in the short-term.

Based on the above, and as we are planning to expand the number of available layer-level actions with future annotation enhancements, it may be a good interim solution to have a confirmation modal for the layer clear and delete actions. Within this proposed confirmation modal, we could also include an opt-out checkbox to never show the modal again for those users that understand the implications and don’t wish to be bothered by it again. I believe this may be a decent short-term compromise to prevent situations like the above, where folks are unclear as to what the button does, or the possibility of mis-clicks due to the proximity of other layer actions that will be added over time.

image

@MichaelMarcialis MichaelMarcialis added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra
Copy link
Contributor

Not sure why this reopened. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants