Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Required][Dashboard] Tabs Project Meta #136680

Closed
24 tasks
ThomThomson opened this issue Jul 19, 2022 · 6 comments
Closed
24 tasks

[Response Required][Dashboard] Tabs Project Meta #136680

ThomThomson opened this issue Jul 19, 2022 · 6 comments
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Jul 19, 2022

Initial Tabs design / UI

  • Place EuiTabs at top of dashboard, under Toolbar, and Unified search bar.
  • Design - Explore ways to reduce vertical space usage
    • Do not show tab bar if only one tab is defined

Tab Management System

  • Toolbar item for tabs.

Manage tabs flyout

  • Delete tab
    • Delete all visualizations in that tab
    • Move all visualizations to a different tab
  • Rename tab
  • Rearrange tabs
    • Drag and drop in vertical list where the order top to bottom matches the order of the tabs left to right?

Add tab Popover

  • Form for title

State Management

  • Dashboard panels contain an id for the tab they exist on

Dashboard Input changes

  • Panel contains tab ID which can be undefined
  • Active tab id
  • Panels object contains
    • title: string
    • id: string
    • order: number
  • Migrations
    • We can avoid having to write migrations by assuming any panel without a tab id exists on the first tab.

Panel Management

  • Action to move panel to tab
  • Add incoming embeddable to last opened tab on return from vis editor

Loading Embeddables on tabs

  • Load subsets of embeddable children
  • Avoid destroying child embeddables on tab change
  • Ensure all data views on a dashboard are communicated to the filter manager properly even if they are on other tabs.
    • We’ll have to watch out for this in multiple data-view dashboards, because we aren’t loading the embeddables until the tab is visited.
    • Visiting a tab could potentially change the available data views.

Reporting

  • Print mode: all tabs load at once stacked on top of each other.
  • Create option for reporting only one tab at a time

App Services Integration

  • Dashboard locator: active tab id in locator
  • Dashboard drilldown: inherit active tab from source dashboard

Controls Integration

  • Place controls under tabs
  • Manage separate Control group inputs without deleting the control group embeddables or their children
  • Modify Dashboard container input to contain Controls per tab.

Considerations for Portable Dashboards

Implementing new pieces of state to manage, while the Portable dashboards project is switching up state management.
Adding new features to dashboard app, when most features will then need to be moved to dashboard container.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:x-large Extra Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@MarianaMartinYuste2 MarianaMartinYuste2 changed the title [Dashboard] Tabs Project Meta [Response Required][Dashboard] Tabs Project Meta Mar 10, 2023
@MarianaMartinYuste2
Copy link

Hello, is there any update I can share with my customer on this request?
Thank you

@ThomThomson
Copy link
Contributor Author

Hello @MarianaMartinYuste2, this project is not yet prioritized, but it is still upcoming. We may start work on it in the next two or three minor versions.

@GoelBiju
Copy link

@ThomThomson definitely a feature that will be useful for a piece of work in the company I am working with. Looking forward to see it progress.

@carmstrong227
Copy link

Also looking forward to progress being made on this functionality, as it would remedy an unfortunate side effect of how we have to deliver dashboards to our clients today (several hundred clients). Being able to leverage such capability would address a number of blank visualizations within dashboards, and therefore, provide a more professional user experience and increase usability for our clients. @ThomThomson Really hoping this project will garner some additional attention sooner than later!

@ThomThomson
Copy link
Contributor Author

Closing this in favour of the Navigation Embeddable project which will be beginning implementation soon. The UI / UX of this will feel very similar to tabs.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants