Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portable Dashboards] Make Dashboard Container Use Redux Embeddable Tools #136771

Closed
Tracked by #133677
ThomThomson opened this issue Jul 20, 2022 · 1 comment · Fixed by #144332
Closed
Tracked by #133677

[Portable Dashboards] Make Dashboard Container Use Redux Embeddable Tools #136771

ThomThomson opened this issue Jul 20, 2022 · 1 comment · Fixed by #144332
Assignees
@ThomThomson
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Prerequisite #133681

The specialized redux implementation used in the Dashboard App should be replaced with the more universal Redux Embeddable tools. This will allow us to store dashboard input, output, and state in redux with automatic syncing, and context tools to enhance interactivity between the embeddable container class and its react component children. This will help us avoid passing many props through many layers of the dashboard, and make the code more maintainable.
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Portable Dashboard Related to the Portable Dashboards initiative labels Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Jul 20, 2022
Closed
7 tasks
@ThomThomson ThomThomson self-assigned this Oct 18, 2022
@ThomThomson ThomThomson mentioned this issue Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Portable Dashboards] Implementation Feature Branch ThomThomson/kibana
2 participants
@ThomThomson @elasticmachine