Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddable] Improve explicit input handling #140397

Closed
dokmic opened this issue Sep 9, 2022 · 3 comments
Closed

[Embeddable] Improve explicit input handling #140397

dokmic opened this issue Sep 9, 2022 · 3 comments
Labels
Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 9, 2022

Background

The current implementation is not as straightforward as it could be. The current implementation holds the state of all the child items in the container. This diverges child implementation into two separate paths when it is inside a container and is self-sufficient.
The merged state is hard to debug, and sometimes it is confusing where the state is coming from.
Resolving this should guarantee support of the nested containers.

Proposal

The base embeddable implementation should be updated to hold its own state regardless of context. The container implementation should be updated accordingly to gather children's states and combine that in the same format as the current implementation.
All methods handling explicit and the default state should be updated to match the existing behavior.

Notes

  • Data access should be bi-directional. For example, filters should go down from the dashboard to the single embeddable.
  • It might be achieved by providing children and parent getters to walk up and down the tree.
  • It is better to approach that by doing an offline exploration and creating a PoC that passes the existing CI pipeline.
@dokmic dokmic added Feature:Embedding Embedding content via iFrame loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:AppServicesUx labels Sep 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:medium Medium Level of Effort labels Sep 9, 2022
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesUx labels Dec 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added Feature:Embeddables Relating to the Embeddable system and removed Feature:Embedding Embedding content via iFrame labels Jun 14, 2023
@ThomThomson
Copy link
Contributor

Closing this in favour of the Embeddables Rebuild initiative.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants